Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Win32 file IO with UWP safe variants and add support for getting drives to UWP build #15652

Merged
merged 6 commits into from
Jul 6, 2022

Conversation

tunip3
Copy link
Contributor

@tunip3 tunip3 commented Jul 5, 2022

This PR replaces all Win32 file IO with UWP safe variants (at least for all file io functions in https://docs.microsoft.com/en-us/windows/win32/api/fileapifromapp/).

This PR also implements drive support into the UWP build, this means that it now actually shows all your drives when you go to the root path.

@hrydgard
Copy link
Owner

hrydgard commented Jul 5, 2022

Good stuff!

The one other major I/O problem we have on UWP is accessing the ISO on the main thread, but maybe it's no longer an issue. That's what created the need for the horrible UWP/StorageFileLoader.cpp. Feel free to see if that can be gotten rid of too in a followup if you like, otherwise I'll take a look relatively soon.

One blocker: You accidentally added the giant file UWP/NATIVEAPP.ipch, we should probably make sure gitignore takes care of it - please remove it and force-push it away so it doesn't get into the PPSSPP repo.

@hrydgard hrydgard added this to the v1.13.0 milestone Jul 5, 2022
@tunip3
Copy link
Contributor Author

tunip3 commented Jul 6, 2022

I have removed the requested file and fixed the indentation, it should be fixed now

@hrydgard
Copy link
Owner

hrydgard commented Jul 6, 2022

Thanks. Will test this tonight, then squash-merge it (so the big file won't end up in history).

@hrydgard
Copy link
Owner

hrydgard commented Jul 6, 2022

Tested this on both Windows and Xbox, worked just fine!

Gonna have to make a faster way to get to the drives root from the default dir, but very nice that it's possible. Thanks!

@hrydgard hrydgard merged commit 42ae18e into hrydgard:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants