Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there a limit of context_keywords in query_tv()? #8

Open
pssguy opened this issue Mar 15, 2017 · 4 comments
Open

Is there a limit of context_keywords in query_tv()? #8

pssguy opened this issue Mar 15, 2017 · 4 comments
Assignees
@hrbrmstr
Labels
enhancement

Comments

@pssguy
Copy link

pssguy commented Mar 15, 2017 

query_tv("trump", "tax,healthcare,wiretap,wiretaps,wiretapping,obamacare,avoidance,returns", start_date="2017-03-12", end_date="2017-03-13")

Error: lexical error: invalid char in json text.
                                       <!DOCTYPE html> <html lang="en-
                     (right here) ------^

If I limit to , say "tax,healthcare,wiretap" no error occurs
@yeedle
Copy link
Contributor

yeedle commented Mar 15, 2017

There's a maximum of 50 characters (imposed by GDELT). Also, don't forget to specify timespan="custom", otherwise it defaults to timespan="all" even when you pass a start_time and end_time

@yeedle
Copy link
Contributor

yeedle commented Mar 15, 2017

@hrbrmstr perhaps this limit should be added as a stopping condition before the query is sent to the api.

@pssguy
Copy link
Author

pssguy commented Mar 15, 2017

Thanks. for swift response It might help to get both these points in vignette

@hrbrmstr hrbrmstr self-assigned this Mar 18, 2017
@hrbrmstr
Copy link
Owner

hrbrmstr commented Mar 18, 2017 •
edited

aye. agreed that a check is needed. and i've been meaning to change the behaviour of how the timespan setting works. ah, the perils of releasing quick wrapper pkg and retrofitting it for production use :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hrbrmstr hrbrmstr

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hrbrmstr @pssguy @yeedle