Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to have output as tibble? #7

Closed
benmarwick opened this issue Jun 19, 2017 · 2 comments
Closed

Possible to have output as tibble? #7

benmarwick opened this issue Jun 19, 2017 · 2 comments

Comments

@benmarwick
Copy link

This is an awesome pkg, and I find assign_colnames useful for all kinds of data input besides docx files.

I wonder if you would consider allowing the tables output by docx_extract_tbl() to be tibbles? For a new data set coming in to my R environment I find it very handy to see the column classes that the tibble print method gives.

Could we change this line to as_tibble(dat) ?

You have tibble in suggests already, so I don't think this will change the dependencies. Just thought I'd ask before making at PR in case you have a good reason not to do this.

@hrbrmstr
Copy link
Owner

in fact, i was quite daft with assign_colnames() as it clobbered input data frame class as well. Things that "shld" return tibbles return tibbles, now and I added some other bits of cleanup I had failed to push earlier. #ty for the suggestion!

@benmarwick
Copy link
Author

benmarwick commented Jun 19, 2017

Thanks very much! I love the new mcga()! (worth a mention in the NEWS, too, no?). It inspired me to push this little add-in out to GitHub: https://github.com/benmarwick/snakecaser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants