Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting ready for a pull request #25

Open
lancecarlson opened this issue Jan 17, 2018 · 0 comments
Open

Getting ready for a pull request #25

lancecarlson opened this issue Jan 17, 2018 · 0 comments

Comments

@lancecarlson
Copy link

lancecarlson commented Jan 17, 2018 •
edited
Loading

I'm expanding on the reporting section of the HelpScout API and have been making commits to my local repo. Mind taking a look at the last two commits on my master branch? There are some inconsistencies with the Ratings code, so I broke some things out. I think in the future, my Report code would completely deprecate the Ratings code. Anyway, I was trying to conform to some of the style that the other calls have, but not completely. Your feedback is appreciated. I'm not 100% done yet, but should have a PR ready for you soon.

https://github.com/lancecarlson/helpscout/commits/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lancecarlson