Actually wait for scheduler to start #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2fb8213
to
ec78544
Compare
ec78544
to
618f67b
Compare
boblail
reviewed
Feb 14, 2022
| @@ -14,6 +14,7 @@ def self.daemonize(name) | |||
| connected_at = Time.now | |||
| Houston.observer.fire "daemon:#{name}:start" | |||
| yield | |||
There was a problem hiding this comment.
Does this line not block while the scheduler is running?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Houston observer event is fired before the call to start the daemon, setting up a potential race condition. We should wait to listen for an event after the call to start the daemon to ensure no queued timers get dropped.