Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ran actions asynchronously with ActiveJob rather than Houston.async #140

Open
wants to merge 53 commits into
base: 0.9-dev
Choose a base branch
from

Conversation

boblail
Copy link
Member

@boblail boblail commented Mar 7, 2017

This has three benefits:

  1. The Active Job Async adapter runs jobs in a thread pool.
  2. It’s now much easier to move to using a backend like Sidekiq instead of threads.
  3. Leveraging Active Job allows Houston instances to choose the right backend for them.

…ions rather than UI, and added the ability to revoke an authorization (1.5h)

Tying authorizations makes it easier to see who added an authorization and who has the ability to delete it; and affords creating multiple authorizations between Houston and a given Provider — for different accounts.

Defining Providers via extensions rather than UI keeps Client secrets out of the database, and allows modules to name providers and declare their dependance on authorizations to a certain provider.

Adding “My Authorizations” allows users to always be able to see their own authorizations and revoke them.
The former “Role” concept modeled multiple roles but is no longer used except to model the concept of a “follower”. The new, simpler, model replaces it.
…ston.async` (20m)

This has three benefits:
  1. The Active Job Async adapter runs jobs in a thread pool.
  2. It’s now much easier to move to using a backend like Sidekiq instead of threads.
  3. Leveraging Active Job allows Houston instances to choose the right backend for them.

# Conflicts:
#	app/models/action.rb
@boblail boblail changed the title Ran actions asynchronously with ActiveJob rather than Houston.async Ran actions asynchronously with ActiveJob rather Houston.async Mar 7, 2017
@boblail boblail changed the title Ran actions asynchronously with ActiveJob rather Houston.async Ran actions asynchronously with ActiveJob rather than Houston.async Mar 7, 2017
@boblail boblail force-pushed the 0.9-dev branch 2 times, most recently from c4992b5 to 1c04023 Compare March 30, 2017 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant