Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems when reproducing pensieve with PyTorch #74

Open
PkuDavidGuan opened this issue Apr 28, 2019 · 2 comments
Open

Problems when reproducing pensieve with PyTorch #74

PkuDavidGuan opened this issue Apr 28, 2019 · 2 comments

Comments

@PkuDavidGuan
Copy link

Dear Hongzi,

I am sorry to bother you, but I went through a few problems when reproducing Pensieve with PyTorch. I found the critic loss is very high (about 30), but the total QoE seems normal(about 40.) I wonder the range of the critic loss after Pensieve's convergence.

@hongzimao
Copy link
Owner

Very nice that you reproducing it in pytorch! I don't remember the range of the loss numbers on top of my head. Also, how do you compute the loss, did you sum it over a batch or you average it? I would recommend you run our code and compare the scale of those numbers.

@qsibmini-khu
Copy link

Dear Hongzi,

I am sorry to bother you, but I went through a few problems when reproducing Pensieve with PyTorch. I found the critic loss is very high (about 30), but the total QoE seems normal(about 40.) I wonder the range of the critic loss after Pensieve's convergence.

Hello, did you finish making the PyTorch version by chance?
It would be a great help.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants