Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Integrating our projects? #34

Closed
wuz opened this issue May 23, 2019 · 4 comments
Closed

Integrating our projects? #34

wuz opened this issue May 23, 2019 · 4 comments

Comments

@wuz
Copy link

wuz commented May 23, 2019

Hi there! I run the unofficial React integration for Honeybadger. I am super excited to see this as an official project! I'd love to discuss deprecating my project and integrating it into this one. Let me know if there is a good process for doing that that you would like to follow!

@joshuap
Copy link
Member

joshuap commented May 24, 2019

Hi @wuz, I don't remember seeing your project before--if I had I would have reached out to you when creating an official one. Thanks for your work on this!

Regarding process, I think it might help if you could take a look through our library and note if there are any differences between our implementation and yours. If you have made improvements that would benefit us, you could suggest changes to our library to port over--feel free to create issues for any changes you think would make sense, and we can discuss them there before implementing.

Once you're satisfied that you can move to using the official integration, you could update your README (and maybe do a final NPM release so that NPM gets the README as well) with a notice explaining the deprecation.

Does that work for you? Thanks again!

@wuz
Copy link
Author

wuz commented May 28, 2019

Hey @joshuap! That sounds like a plan! I'll work on deprecating my project this evening. I don't think there is much of a difference between our implementations, but I'll take a look and see if there is anything I can think of!

I'm excited to help out!

@wuz
Copy link
Author

wuz commented Jun 30, 2019

Took me a lot longer then it should have, but it's been deprecated!

https://www.npmjs.com/package/honeybadger-react

@joshuap
Copy link
Member

joshuap commented Jul 1, 2019

Awesome, thanks @wuz!

@joshuap joshuap closed this as completed Jul 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants