-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
homebridge-winix-purifiers #648
Comments
The following pre-checks failed: ❌ Could not determine plugin name. Comment |
/check |
The following pre-checks failed: ❌ Could not determine plugin name. Comment |
Hi @bcullman Just looking now to see why there are issues with the plugin name. We would also normally want/expect the developer of a plugin to request verification. Are they aware? In agreement? |
/check |
The following pre-checks failed: ❌ Could not determine plugin name. Comment |
/check |
✅ Pre-checks completed successfully. |
hi @bwp91 - This is my bad. I have not checked with the author, @regaw-leinad, I am simply an enthusiastic user of the plugin. I did take a moment to review the verification process, and it sorta seemed like this plugin would have passed straight out. When it didn't, I should have closed the PR, but I got distracted. it does seem the pre-check is passing now. I will proceed however you choose. |
Hi @bcullman and @bwp91 - im only just now seeing this - currently traveling. I appreciate you posting this here for verification. I remember I hadn't taken this step yet due to something i felt was missing from the requirements, but I can't quite remember off the top of my head (and while on mobile). I'll sit down and take a look when I get settled. I'm on board for this as long as it's passing the requirements. |
Comment
|
I'm happy to mark this plugin as verified. There are a couple of items that are technically not satisfied:
This was a new rule that I implemented to push new developers to creating platform-based plugins. Since this is an established plugin already, happy to waive the rule.
Please do this in the future! The Homebridge UI displays release notes when a user updates the plugin, and these are pulled from GitHub, so this is the reasoning for this requirement. @regaw-leinad if you have any questions about this please feel free to reach out 😀 |
Congratulations! Your plugin has been verified. You can now add one of the Verified by Homebridge badges to your plugin's README:
Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions. If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along. Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel! Thank you for your contribution to the Homebridge Community. |
Hey, thanks for this! I just arrived back home and looking into this now
I do now remember this being the reason I didn't push to verify - I hadn't converted this over to a dynamic plugin. I'll look into this moving forward.
Will do! |
Link To GitHub Repo
https://github.com/regaw-leinad/homebridge-winix-purifiers
Link To NPM Package
https://www.npmjs.com/package/homebridge-winix-purifiers
Plugin Icon (Optional)
The text was updated successfully, but these errors were encountered: