Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's Encrypt addon runs irrational port check #1742

Closed
Nicao opened this issue Jan 1, 2021 · 1 comment
Closed

Let's Encrypt addon runs irrational port check #1742

Nicao opened this issue Jan 1, 2021 · 1 comment
Labels

Comments

@Nicao
Copy link

Nicao commented Jan 1, 2021

The problem

When ha is set to listen to port 80 instead of 8123, the add-on fails to start mentioning
"Port '80' is already in use by something else on the host."
which makes sense, given you use the HTTP challenge.

However, as the challenge is a dns challenge it makes no sense to prevent the add-on from starting in this case.

Environment

Let's Encrypt
Current version: 4.11.0

System Health

version 2020.12.1
installation_type Home Assistant OS
dev false
hassio true
docker true
virtualenv false
python_version 3.8.6
os_name Linux
os_version 5.4.84
arch x86_64
timezone Europe/Berlin
Home Assistant Community Store
GitHub API ok
Github API Calls Remaining 4490
Installed Version 1.9.0
Stage running
Available Repositories 702
Installed Repositories 17
Home Assistant Cloud
logged_in false
can_reach_cert_server ok
can_reach_cloud_auth ok
can_reach_cloud ok
Hass.io
host_os Home Assistant OS 5.9
update_channel stable
supervisor_version 2020.12.7
docker_version 19.03.13
disk_total 109.3 GB
disk_used 5.8 GB
healthy true
supported true
board intel-nuc
supervisor_api ok
version_api ok
installed_addons Check Home Assistant configuration (3.6.0), Grocy (0.9.2), deCONZ (6.6.2), File editor (5.2.0), Samba share (9.3.0), Dnsmasq (1.3), FTP (3.5.0), Node-RED (7.2.11), Log Viewer (0.9.1), Home Assistant Google Drive Backup (0.103.0), Let's Encrypt (4.11.0)
Lovelace
dashboards 2
mode auto-gen
resources 3

Problem-relevant configuration

Traceback/Error logs

Additional information

The solution would be to have the add-on checking the config first and read the challenge-type and determine if the port is necessary to use or not.
Since I use the dns challenge I changed the port to a random number, solving the problem.

@stale
Copy link

stale bot commented Mar 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant