-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let's Encrypt addon runs irrational port check #1742
Labels
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The problem
When ha is set to listen to port 80 instead of 8123, the add-on fails to start mentioning
"Port '80' is already in use by something else on the host."
which makes sense, given you use the HTTP challenge.
However, as the challenge is a dns challenge it makes no sense to prevent the add-on from starting in this case.
Environment
Let's Encrypt
Current version: 4.11.0
System Health
Home Assistant Community Store
Home Assistant Cloud
Hass.io
Lovelace
Problem-relevant configuration
Traceback/Error logs
Additional information
The solution would be to have the add-on checking the config first and read the challenge-type and determine if the port is necessary to use or not.
Since I use the dns challenge I changed the port to a random number, solving the problem.
The text was updated successfully, but these errors were encountered: