Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

Unrecognized Token in Lexer always reports Line 1? #98

Open
dantleech opened this issue Feb 17, 2019 · 2 comments
Open

Unrecognized Token in Lexer always reports Line 1? #98

dantleech opened this issue Feb 17, 2019 · 2 comments
Assignees
@Hywan

Comments

@dantleech
Copy link

dantleech commented Feb 17, 2019 •
edited
Loading

👋 The lexer always reports Line 1 when it encounters an unrecognized token:

https://github.com/hoaproject/Compiler/blob/master/Llk/Lexer.php#L151

This is particularly problematic as it the file being parsed has 100s of lines. Guess this is also related to #97
@dantleech dantleech changed the title Invalid Token in Lexer always reports Line 1? Unrecognized Token in Lexer always reports Line 1? Feb 17, 2019
@Hywan
Copy link
Member

Hywan commented Feb 18, 2019

I will work on this. Thanks for the issue!

@Hywan Hywan self-assigned this Feb 18, 2019
@ohader
Copy link

ohader commented Oct 6, 2020

@dantleech Did not spot this issue early, I've created a duplicate in #111 - find corresponding change and new result there

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Hywan Hywan

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ohader @dantleech @Hywan