Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriber needs to unsubscribe and wait #5

Open
hmartiro opened this issue Jan 28, 2015 · 0 comments
Open

Subscriber needs to unsubscribe and wait #5

hmartiro opened this issue Jan 28, 2015 · 0 comments
Labels

Comments

@hmartiro
Copy link
Owner

Right now, there is an explicit pause in the disconnect() method of Subscriber. It seems hiredis requires us to unsubscribe from everything and have no more pending commands, or it gives this type of error:

speed_test_pubsub: async.c:289: __redisAsyncDisconnect: Assertion__redisShiftCallback(&ac->replies,((void *)0)) == -1' failed.`

Contact hiredis guys to see a nicer way around this? Maybe have a cv that waits until there are no more pending hiredis requests, or cancel them somehow.

@hmartiro hmartiro added the bug label Jan 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant