Alpha fixes: Fix issues from alpha1/2 releases #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was not increasing the arguments array, possibly causing IOE
This commit contains a few use-cases in the test: - A message can have fewer arguments than placeholders; - A message can have the same number of arguments and placeholders; - A message can have more arguments than placeholders; Although cases 1 and 3 are inherently "wrong" (data won't be logged/data will be missing), they shouldn't cause the logger to break.
There are many layers in this commit: 1. The new logic is arguably "clearer" and "easier to understand"; 2. The new logic is more correct; and 3. The new logic is more performant. 1. Cleaner: We already know when we put an escape in the string. A double-escape invalidates a single-escape in terms of replacing the placeholder, so moving the check to when we put the escape makes more sense then. 2. More correct: There are a few bugs in the previous logic: - Arguments can be over and we still have placeholders; - `buffer.put(buffer.position() - offset, DELIM_START);` causes chars to go missing; - `null` arguments should be ignored and the placeholders untouched; - escaped placeholders should not leave `\` behind. 3. More performant: Virtually no difference in the benchmark, but logically it makes some sense: - We have more placeholders than usually we have escapes, so we don't need to constantly check the string for escapes. - We do fewer checks (not necessarily a reason for being faster, but still);
There's no need to proxy configs. Much better alternatives will come
We should allow for per-test/block granularity. DEBUG/TRACE can be too verbose for tests, unnecessarily.
This should allow for tests to change their log level in runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few improvements to penna mostly on formatting and internal logic
as they were observed by running
0.7-alpha1and0.7-alpha2versions.Additionally, this PR includes a few improvements to
penna-devfor betterlogging level granularity control.