forked from argoproj/argo-workflows
-
Notifications
You must be signed in to change notification settings - Fork 0
/
gatekeeper_test.go
170 lines (164 loc) · 6.43 KB
/
gatekeeper_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
package auth
import (
"context"
"os"
"testing"
log "github.com/sirupsen/logrus"
"github.com/sirupsen/logrus/hooks/test"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
"google.golang.org/grpc/metadata"
"gopkg.in/square/go-jose.v2/jwt"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
kubefake "k8s.io/client-go/kubernetes/fake"
"k8s.io/client-go/rest"
fakewfclientset "github.com/argoproj/argo-workflows/v3/pkg/client/clientset/versioned/fake"
ssomocks "github.com/argoproj/argo-workflows/v3/server/auth/sso/mocks"
"github.com/argoproj/argo-workflows/v3/server/auth/types"
servertypes "github.com/argoproj/argo-workflows/v3/server/types"
"github.com/argoproj/argo-workflows/v3/workflow/common"
)
func TestServer_GetWFClient(t *testing.T) {
// prevent using local KUBECONFIG - which will fail on CI
_ = os.Setenv("KUBECONFIG", "/dev/null")
defer func() { _ = os.Unsetenv("KUBECONFIG") }()
wfClient := fakewfclientset.NewSimpleClientset()
kubeClient := kubefake.NewSimpleClientset(
&corev1.ServiceAccount{
ObjectMeta: metav1.ObjectMeta{
Name: "my-other-sa", Namespace: "my-ns",
Annotations: map[string]string{
common.AnnotationKeyRBACRule: "'other-group' in groups",
common.AnnotationKeyRBACRulePrecedence: "0",
},
},
Secrets: []corev1.ObjectReference{{Name: "my-secret"}},
},
&corev1.ServiceAccount{
ObjectMeta: metav1.ObjectMeta{
Name: "my-sa", Namespace: "my-ns",
Annotations: map[string]string{
common.AnnotationKeyRBACRule: "'my-group' in groups",
common.AnnotationKeyRBACRulePrecedence: "1",
},
},
Secrets: []corev1.ObjectReference{{Name: "my-secret"}},
},
&corev1.Secret{
ObjectMeta: metav1.ObjectMeta{Name: "my-secret", Namespace: "my-ns"},
Data: map[string][]byte{
"token": {},
},
},
)
var clientForAuthorization ClientForAuthorization = func(authorization string) (*rest.Config, *servertypes.Clients, error) {
return &rest.Config{}, &servertypes.Clients{Workflow: &fakewfclientset.Clientset{}, Kubernetes: &kubefake.Clientset{}}, nil
}
clients := &servertypes.Clients{Workflow: wfClient, Kubernetes: kubeClient}
t.Run("None", func(t *testing.T) {
_, err := NewGatekeeper(Modes{}, clients, nil, nil, clientForAuthorization, "")
assert.Error(t, err)
})
t.Run("Invalid", func(t *testing.T) {
g, err := NewGatekeeper(Modes{Client: true}, clients, nil, nil, clientForAuthorization, "")
if assert.NoError(t, err) {
_, err := g.Context(x("invalid"))
assert.Error(t, err)
}
})
t.Run("NotAllowed", func(t *testing.T) {
g, err := NewGatekeeper(Modes{SSO: true}, clients, nil, nil, clientForAuthorization, "")
if assert.NoError(t, err) {
_, err := g.Context(x("Bearer "))
assert.Error(t, err)
}
})
t.Run("Client", func(t *testing.T) {
g, err := NewGatekeeper(Modes{Client: true}, clients, &rest.Config{Username: "my-username"}, nil, clientForAuthorization, "")
assert.NoError(t, err)
ctx, err := g.Context(x("Bearer "))
if assert.NoError(t, err) {
assert.NotEqual(t, wfClient, GetWfClient(ctx))
assert.NotEqual(t, kubeClient, GetKubeClient(ctx))
assert.Nil(t, GetClaims(ctx))
}
})
t.Run("Server", func(t *testing.T) {
g, err := NewGatekeeper(Modes{Server: true}, clients, &rest.Config{Username: "my-username"}, nil, clientForAuthorization, "")
assert.NoError(t, err)
ctx, err := g.Context(x(""))
if assert.NoError(t, err) {
assert.Equal(t, wfClient, GetWfClient(ctx))
assert.Equal(t, kubeClient, GetKubeClient(ctx))
assert.NotNil(t, GetClaims(ctx))
}
})
t.Run("SSO", func(t *testing.T) {
ssoIf := &ssomocks.Interface{}
ssoIf.On("Authorize", mock.Anything, mock.Anything).Return(&types.Claims{Claims: jwt.Claims{Subject: "my-sub"}}, nil)
ssoIf.On("IsRBACEnabled").Return(false)
g, err := NewGatekeeper(Modes{SSO: true}, clients, nil, ssoIf, clientForAuthorization, "my-ns")
if assert.NoError(t, err) {
ctx, err := g.Context(x("Bearer v2:whatever"))
if assert.NoError(t, err) {
assert.Equal(t, wfClient, GetWfClient(ctx))
assert.Equal(t, kubeClient, GetKubeClient(ctx))
if assert.NotNil(t, GetClaims(ctx)) {
assert.Equal(t, "my-sub", GetClaims(ctx).Subject)
}
}
}
})
hook := &test.Hook{}
log.AddHook(hook)
defer log.StandardLogger().ReplaceHooks(nil)
t.Run("SSO+RBAC,precedence=1", func(t *testing.T) {
ssoIf := &ssomocks.Interface{}
ssoIf.On("Authorize", mock.Anything, mock.Anything).Return(&types.Claims{Groups: []string{"my-group", "other-group"}}, nil)
ssoIf.On("IsRBACEnabled").Return(true)
g, err := NewGatekeeper(Modes{SSO: true}, clients, nil, ssoIf, clientForAuthorization, "my-ns")
if assert.NoError(t, err) {
ctx, err := g.Context(x("Bearer v2:whatever"))
if assert.NoError(t, err) {
assert.NotEqual(t, clients, GetWfClient(ctx))
assert.NotEqual(t, kubeClient, GetKubeClient(ctx))
if assert.NotNil(t, GetClaims(ctx)) {
assert.Equal(t, []string{"my-group", "other-group"}, GetClaims(ctx).Groups)
assert.Equal(t, "my-sa", GetClaims(ctx).ServiceAccountName)
}
assert.Equal(t, "my-sa", hook.LastEntry().Data["serviceAccount"])
}
}
})
t.Run("SSO+RBAC,precedence=0", func(t *testing.T) {
ssoIf := &ssomocks.Interface{}
ssoIf.On("Authorize", mock.Anything, mock.Anything).Return(&types.Claims{Groups: []string{"other-group"}}, nil)
ssoIf.On("IsRBACEnabled").Return(true)
g, err := NewGatekeeper(Modes{SSO: true}, clients, nil, ssoIf, clientForAuthorization, "my-ns")
if assert.NoError(t, err) {
ctx, err := g.Context(x("Bearer v2:whatever"))
if assert.NoError(t, err) {
assert.Equal(t, "my-other-sa", hook.LastEntry().Data["serviceAccount"])
assert.Equal(t, "my-other-sa", GetClaims(ctx).ServiceAccountName)
}
}
})
t.Run("SSO+RBAC,denied", func(t *testing.T) {
ssoIf := &ssomocks.Interface{}
ssoIf.On("Authorize", mock.Anything, mock.Anything).Return(&types.Claims{}, nil)
ssoIf.On("IsRBACEnabled").Return(true)
g, err := NewGatekeeper(Modes{SSO: true}, clients, nil, ssoIf, clientForAuthorization, "my-ns")
if assert.NoError(t, err) {
_, err := g.Context(x("Bearer v2:whatever"))
assert.EqualError(t, err, "rpc error: code = PermissionDenied desc = not allowed")
}
})
}
func x(authorization string) context.Context {
return metadata.NewIncomingContext(context.Background(), metadata.New(map[string]string{"authorization": authorization}))
}
func TestGetClaimSet(t *testing.T) {
// we should be able to get nil claim set
assert.Nil(t, GetClaims(context.TODO()))
}