Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make collection REUSE-compliant #199

Merged
merged 3 commits into from
May 6, 2024
Merged

Make collection REUSE-compliant #199

merged 3 commits into from
May 6, 2024

Conversation

Normo
Copy link
Member

@Normo Normo commented Mar 18, 2024

@Normo Normo added this to the v4.0.0 milestone Mar 18, 2024
@Normo Normo self-assigned this Mar 18, 2024
@Normo Normo changed the base branch from main to release-version-4.0.0 March 18, 2024 14:17
@github-actions github-actions bot added the unattended_upgrades Related to role hifis.unattended_upgrades label May 3, 2024
@Normo Normo marked this pull request as ready for review May 3, 2024 13:05
@Normo Normo requested a review from a team as a code owner May 3, 2024 13:05
@Normo Normo force-pushed the 197-reuse-compliance branch 3 times, most recently from 838dbb1 to ee33577 Compare May 3, 2024 13:16
@Normo Normo requested a review from tobiashuste May 3, 2024 13:16
@Normo Normo force-pushed the 197-reuse-compliance branch 3 times, most recently from 0f0a105 to 50e1265 Compare May 6, 2024 08:19
tobiashuste
tobiashuste reviewed May 6, 2024
View reviewed changes
Copy link
Member

@tobiashuste tobiashuste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Normo!

Only one thought. Do you think we should remove the year from the copyright notices? This could simpliy handling of those headers a little.

@Normo Normo mentioned this pull request May 6, 2024
Merged
@Normo
Copy link
Member Author

Normo commented May 6, 2024

Only one thought. Do you think we should remove the year from the copyright notices? This could simpliy handling of those headers a little.

Good point @tobiashuste. That makes adding the other roles easier. Updated the copyright header accordingly.

@Normo Normo requested a review from tobiashuste May 6, 2024 09:10
Norman Ziegner and others added 3 commits May 6, 2024 11:18
@Normo Normo merged commit cbc8ee3 into hifis-net:release-version-4.0.0 May 6, 2024
10 checks passed
@Normo Normo deleted the 197-reuse-compliance branch May 6, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiashuste tobiashuste tobiashuste approved these changes

Assignees

@Normo Normo

Labels
unattended_upgrades Related to role hifis.unattended_upgrades
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

Make collection REUSE-compliant
2 participants
@Normo @tobiashuste