-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differentiating between edge types at the API level #26
Comments
If we go with three different functions, it would be nice to avoid duplication of argument definitions and docstrings. Not sure the best way to do this. One possible option is to use classes / subclasses. These could be helpful for tracking the stats as well. |
Another option is that we could have a single function but take an argument like If we do have three different functions, possibly |
I am thinking we want three user-facing functions to perform the permutation. They could be named like:
I think this would be clearest for the user. You could remove the confusing
allow_self_loop
from permute_bipartite_edges.allow_antiparallel
would only be an option forpermute_directed_edges
. Alsopermute_undirected_edges
could mix sources or targets when swapping to achieve greater potential permutations?@zietzm, do you think this makes sense?
The text was updated successfully, but these errors were encountered: