Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use successes rather than attempts as stop condition #25

Open
dhimmel opened this issue Aug 26, 2019 · 0 comments
Open

Use successes rather than attempts as stop condition #25

dhimmel opened this issue Aug 26, 2019 · 0 comments

Comments

@dhimmel
Copy link
Member

dhimmel commented Aug 26, 2019

Since only successful swaps advance the network randomization, it doesn't make a ton of sense to me to set an attempt threshold as the stop condition versus a success threshold. This has been bothering me since I initially implemented the attempt threshold in hetnetpy.

To prevent infinite running, we could enable a max_attempts parameter, perhaps that is a multiplier for based on the specified number of successes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant