Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metapath abbreviation in ''Project Rephetio Metapaths'' table #3

Closed
yhao-compbio opened this issue May 31, 2019 · 5 comments
Closed

Comments

@yhao-compbio
Copy link

yhao-compbio commented May 31, 2019

https://het.io/repurpose/metapaths.html

In the table above, metapaths that contain 'G<rG' show incorrect abbreviation.

Example:

CbG | 4 | 3.16% | 1.1931 |   | Compound–binds–Gene←regulates←Gene–upregulates–Disease–resembles–Disease

@dhimmel
Copy link
Member

dhimmel commented May 31, 2019

Okay this table is loaded at:

$('#metapath_table').DataTable({
ajax: `${data_url}metapaths.json`,
aoColumnDefs: aoColumnDefs,
pageLength: 25,
order: [[1, 'asc'], [0, 'asc']],
})

data_url is defined at:

var data_url = 'https://raw.githubusercontent.com/dhimmel/het.io-rep-data/1a960f0e353586f8fe9f61b569919f24603d4344/browser-tables/';

So this is the complete URL where the JSON table data is loaded. The source data in this file looks OKAY:

  [
   "CbG<rGuDrD",
   4,
   0.031557,
   1.1931,
   null,
   "Compound\u2013binds\u2013Gene\u2190regulates\u2190Gene\u2013upregulates\u2013Disease\u2013resembles\u2013Disease"
  ],

So the issue must be with how the value of CbG<rGuDrD is rendered as a table cell. My guess is that the < is being mistakenly interpreted as the start of an HTML tag.

@dhimmel
Copy link
Member

dhimmel commented May 31, 2019

Will probably defer fixing this until @vincerubinetti revamps the het.io website... unless there is an easy fix that someone points out (or submits a PR for).

@vincerubinetti
Copy link
Collaborator

@dhimmel update on this?

@dhimmel
Copy link
Member

dhimmel commented Aug 8, 2019

It's fixed in the prototype at https://hetio.github.io/repurpose-frontend/?tab=metapaths, so we'll close when we've fully rolled out the new apps.

@dhimmel
Copy link
Member

dhimmel commented Aug 20, 2019

@yhao-compbio, we've released the new version of the /repurpose page. This metapaths table can now be browsed at https://het.io/repurpose/?tab=metapaths without any errant truncation of abbreviations!

@vincerubinetti I noticed that we still need to redirect https://het.io/repurpose/metapaths.html to https://het.io/repurpose/?tab=metapaths. Update: fixed in e2d4550

@dhimmel dhimmel closed this as completed Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants