Rename VersionLayerClient to VersionedLayerClient #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OleksiiZubko
requested changes
Oct 31, 2019
| @@ -96,7 +95,7 @@ export class CatalogClient { | |||
| this.context.getToken | |||
| ), | |||
| { catalogHrn: this.hrn } | |||
| ).catch((err: Response) => | |||
| ).catch(err => | |||
There was a problem hiding this comment.
Why did you remove that?
| @@ -117,7 +116,7 @@ export class CatalogClient { | |||
| */ | |||
| public async getVolatileOrVersionedLayer( | |||
| layerName: string | |||
| // tslint:disable-next-line: deprecation | |||
| // tslint:disable-next-line: deprecation | |||
There was a problem hiding this comment.
this formatting is done by commit hook?
Comment on lines
+296
to
+301
| layerClient = new VersionedLayerClient({ | ||
| context: this.context, | ||
| hrn: this.hrn, | ||
| layerId: config.id, | ||
| version: version === undefined ? -1 : version | ||
| }); |
There was a problem hiding this comment.
Why do we need that?
Comment on lines
+38
to
+59
| /** | ||
| * Parameters for `VersionedLayerClient` constructor. | ||
| */ | ||
| export interface VersionedLayerClientParams { | ||
| /** | ||
| * Context which stores and caches the shared information needed for that clients | ||
| */ | ||
| context: DataStoreContext; | ||
| /** | ||
| * Specify the catalog HRN | ||
| */ | ||
| hrn: string; | ||
| /** | ||
| * Layer id. It is used as layer main identifier in api queries | ||
| */ | ||
| layerId: string; | ||
| /** | ||
| * Specify which version of layer should be used. | ||
| */ | ||
| version: number; | ||
| } | ||
|
|
There was a problem hiding this comment.
Why do we need that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename VersionLayerClient to VersionedLayerClient.
Performed rename VersionLayerClient to VersionedLayerClient.
Relates-To: OLPEDGE-904
Signed-off-by: Bautista, Iryna [email protected]