Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VersionedLayerClient constructor #23

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Conversation

AndriyShevchuk
Copy link
Contributor

@AndriyShevchuk AndriyShevchuk commented Oct 30, 2019

  • Update VersionedLayerClient constructor,
  • Add getLatestVersion method,
  • Update tests

Resolves: OLPEDGE-922
Signed-off-by: ashevchu [email protected]

@@ -31,38 +31,16 @@ import {
MetadataApi,
QueryApi
} from "@here/olp-sdk-dataservice-api";
import { HRN } from "@here/olp-sdk-dataservice-read";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

../HRN ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator

@andescu andescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adapt the commit message a little.
Use bullet points if you want to separate individual changes.

* Update VersionedLayerClient constructor,
* Add getLatestVersion method,
* Update tests

Resolves: OLPEDGE-922
Signed-off-by: ashevchu <[email protected]>
@OleksiiZubko OleksiiZubko merged commit 35d81b3 into master Oct 31, 2019
@OleksiiZubko OleksiiZubko deleted the task/olpedge-922 branch October 31, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants