Create StatisticsClient class #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OleksiiZubko
requested changes
Oct 28, 2019
| export class StatisticsClient { | ||
| public readonly context: DataStoreContext; | ||
|
|
||
| constructor(context: DataStoreContext) { |
There was a problem hiding this comment.
Can we use like this: constructor(private readonly context: DataStoreContext) { } ?
| @@ -0,0 +1,31 @@ | |||
| import { DataStoreContext } from "./DataStoreContext"; | |||
There was a problem hiding this comment.
Please, move after Licence
593d2f3
to
f33b02c
Compare
OleksiiZubko
requested changes
Oct 29, 2019
| */ | ||
| export class StatisticsClient { | ||
| constructor(private readonly context: DataStoreContext) { | ||
| this.context = context; |
There was a problem hiding this comment.
Please, remove this.context = context;
| return Promise.reject(new Error(`No layerId provided`)); | ||
| } | ||
| const coverageRequestBuilder = await this.getRequestBuilder(summaryRequest.catalogHrn) | ||
| .catch(error => error); |
There was a problem hiding this comment.
.catch(error => error); Maybe should be returned Promise.reject from getSummary ?
| }).catch(this.errorHandler); | ||
| } | ||
|
|
||
| private async errorHandler(error: any) { |
There was a problem hiding this comment.
could you please not use any?
| private _catalogHrn: string | undefined; | ||
| private _layerId: string | undefined; | ||
|
|
||
| get catalogHrn(): string | undefined { |
There was a problem hiding this comment.
could you please use getCatalogHrn() to align with C++?
| get layerId(): string | undefined { | ||
| return this._layerId; | ||
| } | ||
| set layerId(layerId: string | undefined) { |
There was a problem hiding this comment.
We don't need this setter? we have withLayerId
4505d3c
to
f772d38
Compare
Create StatisticsClient class, add constructor and unit-tests Add getSummary method to fetch summary data from CoverageApi Create SummaryRequest class to add parameters to the getSummary method Resolves: OLPEDGE-939, OLPEDGE-940 Signed-off-by: ashevchu <[email protected]>
f772d38
to
83e5abe
Compare
OleksiiZubko
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create StatisticsClient class, add constructor and unit-tests
Add getSummary method to fetch summary data from CoverageApi
Create SummaryRequest class to add parameters to the getSummary method
Resolves: OLPEDGE-939, OLPEDGE-940
Signed-off-by: ashevchu [email protected]