Extension of KeyValueCache interface #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b9d012
to
e5010c9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1513 +/- ##
==========================================
- Coverage 81.50% 81.39% -0.11%
==========================================
Files 341 342 +1
Lines 13417 13481 +64
Branches 1447 1451 +4
==========================================
+ Hits 10935 10972 +37
- Misses 1904 1927 +23
- Partials 578 582 +4 ☔ View full report in Codecov by Sentry. |
Added main operations like Read, Write, Remove. The difference with the old one is that new API may return actual error instead of cryptic `false`. DefaultCache implementation was extended as well to cover new methods. Relates-To: OCMAM-3, OAM-2431 Signed-off-by: Andrey Kashcheev <[email protected]>
e5010c9
to
18a8c78
Compare
rustam-gamidov-here
approved these changes
May 21, 2024
mykhailo-kuchma
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added main operations like Read, Write, Remove.
The difference with the old one is that new API may return actual error instead of cryptic
false.DefaultCache implementation was extended as well
to cover new methods.
Relates-To: OCMAM-3, OAM-2431