Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [Breaking] Rule IP / Endpoint parsing fails. Might cause Firewall to not work at all! #1592

Closed
2 tasks done
Silberling opened this issue Oct 11, 2023 · 2 comments
Closed
2 tasks done
Labels

Comments

@Silberling
Copy link

Checklist

  • I have used the search function to see if someone else has already submitted the same bug report.
  • I will describe the problem with as much detail as possible.

App version

3.7.3

Windows version

Windows 10 Pro for Workstations 22H2 19045.3570

Steps to reproduce

I found this error when in log packages appeared where ALLOW rules were made for. My whole local network software does not work anymore with this simplewall version. When I checked my rules for errors I found this:

  1. Go To User rules
  2. Edit any rule
  3. Go to Rule tab
  4. Add remote with 192.168.0.0/24
  5. ERROR: "Syntax error in rule!"

Expected behavior

I expect previous rules to work
I expect example syntax to work
I kindly suggest adding unit tests to the code, even for such simple things, to avoid this in the future.

Actual behavior

Firewall stops traffic
Rules not editable
False error messages

Logs

No response

@Silberling Silberling added the bug label Oct 11, 2023
@Silberling
Copy link
Author

Found this when updating to specified version. Just reverted back to 3.7.2 -> Everything fine again. Suggest to flag 3.7.3 and avoid installing.

@henrypp
Copy link
Owner

henrypp commented Oct 12, 2023

it is already fixed, redownload 3.7.3

@henrypp henrypp closed this as completed Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants