Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable buffrs::build installing dependencies if we are doing a release build #55

Open
mara-schulke opened this issue Sep 15, 2023 · 0 comments
Labels
complexity::low Issues or ideas with a low implementation cost priority::high Urgent change or idea, please review quickly type::idea Rough idea or proposal for buffrs type::refactoring Changing the inner-workings of buffrs

Comments

@mara-schulke
Copy link
Contributor

Or rephrased: Only install missing deps if we are running a debug build and give a nice error hinting on why it is not possible otherwise


Root cause: When running a release build using cargo in a freshly cloned project, we get an error complaining about buffrs modifing the working dir. This is intended cargo behavior and can be bypassed by --no-verify. In order to give a better error to the user we should not be downloading anything in release builds and error early if dependencies are missing.

In debug builds we want to keep the plug and play nature.

@mara-schulke mara-schulke added this to the Stabilization milestone Sep 15, 2023
@mara-schulke mara-schulke added complexity::low Issues or ideas with a low implementation cost priority::high Urgent change or idea, please review quickly type::refactoring Changing the inner-workings of buffrs type::idea Rough idea or proposal for buffrs labels Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity::low Issues or ideas with a low implementation cost priority::high Urgent change or idea, please review quickly type::idea Rough idea or proposal for buffrs type::refactoring Changing the inner-workings of buffrs
Projects
Status: Todo
Development

No branches or pull requests

1 participant