Unclear error message for #192

[qsantos]

From #192:

~% git clone git@github..........
~% cd my-project
~/my-project% buffrs install
Error:   × failed to install dependencies for `my-project`
  ╰─▶ No such file or directory (os error 2)

The error message does not help understanding that the issue comes from the missing proto/vendor/ directory.

[qsantos]

The error message comes from:

buffrs/src/package/store.rs

Line 53 in 4a6d0e9

let meta = fs::metadata(&self.proto_path()).await.into_diagnostic()?;

The core::result::Result returned by the Future is converted into a miette::Result but no context message is attached.

Would it make sense to require that any call to into_diagnostic() be followed by a call to wrap_err()? Maybe we could make a lint for that.

[qsantos]

Note, however, that the full function is:

buffrs/src/package/store.rs

Lines 51 to 56 in 4a6d0e9

	/// Check if this store exists
	async fn exists(&self) -> miette::Result<bool> {
	let meta = fs::metadata(&self.proto_path()).await.into_diagnostic()?;
	Ok(meta.is_dir())
	}

This function will only return Ok(false) if the entry exists but is not a directory. In this case, maybe it would make more sense to do:

    /// Check if this store exists
    async fn exists(&self) -> bool {
        fs::metadata(&self.proto_path()).await.is_ok_and(|meta| meta.is_dir())
    }

[gbouv]

This seems to be fixed right? I tried to repro and now buffrs automatically create the proto/vendor directory. Can this issue be closed?