Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit Error handling: don't return miette::Result from low-level types #137

Open
xfbs opened this issue Oct 20, 2023 · 0 comments
Open

Revisit Error handling: don't return miette::Result from low-level types #137

xfbs opened this issue Oct 20, 2023 · 0 comments
Assignees
@xfbs
Labels
complexity::low Issues or ideas with a low implementation cost docs::project Documenting the project vision, design decisions etc priority::low Please dont work on this if you can contribute something with a higher priority type::idea Rough idea or proposal for buffrs type::refactoring Changing the inner-workings of buffrs type::style Related to personal or community opinions

Comments

@xfbs
Copy link
Contributor

xfbs commented Oct 20, 2023

Look into the error handling discussions and see if it is really necessary to return miette::Result from low-level implementations (such as FromStr) and methods.

My general feeling is that this is not the right thing to do, but there has been some previous discussion about it that I need to catch up. If the current approach is correct, I will close this issue.
@xfbs xfbs self-assigned this Oct 20, 2023
@mara-schulke mara-schulke added complexity::low Issues or ideas with a low implementation cost type::style Related to personal or community opinions type::refactoring Changing the inner-workings of buffrs type::idea Rough idea or proposal for buffrs docs::project Documenting the project vision, design decisions etc priority::low Please dont work on this if you can contribute something with a higher priority labels Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xfbs xfbs

Labels
complexity::low Issues or ideas with a low implementation cost docs::project Documenting the project vision, design decisions etc priority::low Please dont work on this if you can contribute something with a higher priority type::idea Rough idea or proposal for buffrs type::refactoring Changing the inner-workings of buffrs type::style Related to personal or community opinions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xfbs @mara-schulke