Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move out PackageStore::release() from PackageStore #136

Open
xfbs opened this issue Oct 20, 2023 · 0 comments
Open

Move out PackageStore::release() from PackageStore #136

xfbs opened this issue Oct 20, 2023 · 0 comments
Assignees
@xfbs
Labels
datamodel Changes related to the Datamodel priority::low Please dont work on this if you can contribute something with a higher priority type::refactoring Changing the inner-workings of buffrs type::style Related to personal or community opinions
Milestone
Stabilization

Comments

@xfbs
Copy link
Contributor

xfbs commented Oct 20, 2023

The PackageStore has only one responsibility: that is storing packages. As such, it "owns" the data inside proto/vendor. It should not really be responsible for releasing packages.

For that reason, we should move out the logic for releasing packages into a separate module, perhaps the Package module.
@xfbs xfbs self-assigned this Oct 20, 2023
@mara-schulke mara-schulke added datamodel Changes related to the Datamodel type::style Related to personal or community opinions type::refactoring Changing the inner-workings of buffrs priority::low Please dont work on this if you can contribute something with a higher priority labels Oct 20, 2023
@mara-schulke mara-schulke added this to the Stabilization milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xfbs xfbs

Labels
datamodel Changes related to the Datamodel priority::low Please dont work on this if you can contribute something with a higher priority type::refactoring Changing the inner-workings of buffrs type::style Related to personal or community opinions
Projects
Buffrs
Status: No status
Milestone
Stabilization
Development

No branches or pull requests
2 participants
@xfbs @mara-schulke