Allow filtering fetched or built languages when using --grammar #6633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to having
use-grammars
inlanguages.toml
, this PR implements allowing users the filter which grammars are fetched or built by passing a list of languages as a parameter to--grammar fetch
or--grammar build
.If no list is provided all available grammars are fetched or built as is current behaviour as well.
Example output
Rationale behind this feature is allowing users to only download the few grammars they might need, without having to mess around with configuration files.
One question arises however with how this should interact with the
use-grammars
field inlanguages.toml
. With the current implementation settings configured inlanguages.toml
are still honoured, but maybe it would make more sense for those settings to be overridden by the list supplied to the--grammar
parameter?