Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reload_all command should ignore scratch buffers #5665

Open
manokara opened this issue Jan 24, 2023 · 4 comments · May be fixed by #5983
Open

reload_all command should ignore scratch buffers #5665

manokara opened this issue Jan 24, 2023 · 4 comments · May be fixed by #5983
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors

Comments

@manokara
Copy link

I often run a script to strip trailing whitespace from all changed files since the last git commit, and use :reload-all so helix picks up on the new changes. However, if I have any scratch buffer open it will short-circuit the reloading process, which I believe is not good UX. It would make sense if a file could not be found for normal buffers, and a :reload-all! command could be added to ignore such situations.

This should probably be a trivial change. I'll work on it on my own fork when I have time and then make a PR for it.
@manokara manokara added the C-enhancement Category: Improvements label Jan 24, 2023
@the-mikedavis the-mikedavis added the A-helix-term Area: Helix term improvements label Jan 24, 2023
@kirawi kirawi added E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors labels Feb 5, 2023
@KenCox94
Copy link

@manokara was hoping I could tackle this if you are too busy. I have a fix but wanted to consult with you directly since it is your issue.

@manokara
Copy link
Author

@KenCox94 Oh, please do go ahead! Haven't really had much time these days. Are you planning on working on the reload-all! idea as well?

@KenCox94
Copy link

@manokara yes! I implemented exactly what you laid out!

@KenCox94 KenCox94 linked a pull request Feb 14, 2023 that will close this issue
Open
@KenCox94
Copy link

check it out @manokara, been programming in rust for about a year....so any notes are welcomed!

@kirawi kirawi mentioned this issue Aug 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reload_all! KenCox94/helix
4 participants
@manokara @the-mikedavis @KenCox94 @kirawi