Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement window/showMessage in LSP client #5524

Open
ayoub-benali opened this issue Jan 13, 2023 · 1 comment · May be fixed by #5535
Open

Implement window/showMessage in LSP client #5524

ayoub-benali opened this issue Jan 13, 2023 · 1 comment · May be fixed by #5535
Labels
A-language-server Area: Language server client C-enhancement Category: Improvements

Comments

@ayoub-benali
Copy link
Contributor

ayoub-benali commented Jan 13, 2023 •
edited
Loading

Currently Helix is simply logging a warning here:

helix/helix-term/src/application.rs

Line 821 in b633139

log::warn!("unhandled window/showMessage: {:?}", params);

while Scala's language server Metals make use of it. You can see it in the spec.

I saw that there was some work by @matoous in #1445 but it is dropped. So I want first to get some ideas on how handle this message.
Is bellow the status line for example a good place like the progress messages? should it be configurable and off by default like display-messages ?
@ayoub-benali ayoub-benali added the C-enhancement Category: Improvements label Jan 13, 2023
@the-mikedavis the-mikedavis added the A-language-server Area: Language server client label Jan 13, 2023
ayoub-benali added a commit to ayoub-benali/helix that referenced this issue Jan 14, 2023
@ayoub-benali
Handle window/showMessage and display it bellow status line
74a9faf 
This feature is also hidden behind the `display-messages` which is used for displaying [Progress](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#progress).

Fix helix-editor#5524
@ayoub-benali ayoub-benali linked a pull request Jan 14, 2023 that will close this issue
Open
ayoub-benali added a commit to ayoub-benali/helix that referenced this issue Jan 22, 2023
@ayoub-benali
Handle window/showMessage and display it bellow status line
663a2e5 
This feature is also hidden behind the `display-messages` which is used for displaying [Progress](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#progress).

Fix helix-editor#5524
ayoub-benali added a commit to ayoub-benali/helix that referenced this issue Jan 27, 2023
@ayoub-benali
Handle window/showMessage and display it bellow status line
d16ad37 
This feature is also hidden behind the `display-messages` which is used for displaying [Progress](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#progress).

Fix helix-editor#5524
@pascalkuthe pascalkuthe mentioned this issue Mar 14, 2023
Closed
@sigmaSd
Copy link
Contributor

sigmaSd commented Jul 27, 2023

https://github.com/v-analyzer/v-analyzer also uses it

@filipwiech filipwiech mentioned this issue Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-language-server Area: Language server client C-enhancement Category: Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle window/showMessage and display it bellow status line ayoub-benali/helix
3 participants
@ayoub-benali @the-mikedavis @sigmaSd