Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run-shell-command async / on another thread #3506

Closed
paulcomte opened this issue Aug 22, 2022 · 3 comments
Closed

run-shell-command async / on another thread #3506

paulcomte opened this issue Aug 22, 2022 · 3 comments
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@paulcomte
Copy link

Describe your feature request

Hey!

When executing sh cargo check helix stops responding, it looks like sh is being executed on the main thread.
But I'd like to be able to continue editing my code while I use any sh command.
(I ran sh cargo check to import a dependency, but whilst its being downloaded I'd like to continue editing)

Feature: Run sh asynchronously or on another thread

Best regards

@paulcomte paulcomte added the C-enhancement Category: Improvements label Aug 22, 2022
@paulcomte paulcomte changed the title run-shell-command run-shell-command async / on another thread Aug 22, 2022
@the-mikedavis the-mikedavis linked a pull request Aug 22, 2022 that will close this issue
@the-mikedavis the-mikedavis added the A-helix-term Area: Helix term improvements label Aug 22, 2022
@the-mikedavis
Copy link
Member

There's a PR for this: #3029. IMO it could be the default behavior for :sh.

I wouldn't recommend using :sh for running builds or tests like cargo check though: it's meant to make it possible to bind keys to shell commands rather than be a replacement for a full terminal emulator like #1976. For shell commands that take some time or have non-trivial output I would recommend running the command in a separate shell (a separate tmux or terminal emulator window/split)

@paulcomte
Copy link
Author

Oh didn't check if there was any PR regarding this issue,

Yeah normally I'm using another shell, but I tried to run it in helix directly because it seemed easier.

@pascalkuthe
Copy link
Member

Closed by #6373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants