-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve/fix some built in themes #3314
Comments
I agree, and made a tool for helping out #3234. A lot of the issues you point out are not yet checked against, but they could :) |
About base16_transparent, it is intentionally the same as the background. |
Some of these might be intentional and fixes would be a bit opinionated. Pinging @two-six for Acme, Nord Light
Makes sense, added a note. |
Thanks for the ping, I'll look into fixing acme. |
It is very hard to read the undefined |
Acme uses a mix of hard coded colors and colors derived from the terminal theme. That's why it can look pretty bad when a dark terminal theme is used. The issue for the Nord Light errors is that you used |
@olbitset I have already fixed this in #5019, it just wasn't included in the latest release. You would need to compile helix from source or update |
Thanks @two-six I included as a personal theme. What about the TOP bufferline (as the selection one), is it expected to have a gray background? If so what is the parameter in the toml config to adapt it to my need? |
Do you mean foreground? I see background is light blue in your screenshot, not gray. Set I've never used bufferline before, but as you mentioned current configuration doesn't really fit this theme really well. I will open a pull request to change it from gray to black. |
Sorry I was talking about the bg. Thanks for the inputs I will adapt to my preferences! |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Some themes that come with helix need some polish.
acme: statusline, menu, maybe errors
base_16_transparent: menu bg same as standard bg (intentional, add border once it's possible)
nord_light: ui menu selected bg very similar to standard bg
rose_pine_dawn: ui menu selected bg same as standard bg
FIXED
dark_plus: indent guide bg
ayu_light: statusline fg, menu fg
The text was updated successfully, but these errors were encountered: