Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bracket pair colourization / Rainbow parenthesis #695

Open
kirawi opened this issue Sep 2, 2021 · 8 comments · May be fixed by #2857
Open

Bracket pair colourization / Rainbow parenthesis #695

kirawi opened this issue Sep 2, 2021 · 8 comments · May be fixed by #2857
Assignees
@the-mikedavis
Labels
A-helix-term Area: Helix term improvements A-theme Area: Theme and appearence related C-enhancement Category: Improvements

Comments

@kirawi
Copy link
Member

kirawi commented Sep 2, 2021 •
edited
Loading

https://marketplace.visualstudio.com/items?itemName=CoenraadS.bracket-pair-colorizer-2
microsoft/vscode#129231
@kirawi kirawi added C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much A-helix-term Area: Helix term improvements A-theme Area: Theme and appearence related and removed E-easy Call for participation: Experience needed to fix: Easy / not much labels Sep 2, 2021
@archseer archseer changed the title Bracket Pair Colourization Bracket pair colourization Sep 2, 2021
@pickfire pickfire changed the title Bracket pair colourization Bracket pair colourization / Rainbow parenthesis Sep 3, 2021
@Th3Whit3Wolf
Copy link

This was just moved into core

@archseer
Copy link
Member

With tree-sitter we can likely do this in a much easier way: simply scan the start and end of each named node. VSCode still relies on textmate grammars so it has to parse the whole file by hand to determine matching pairs.

@ttys3
Copy link
Contributor

ttys3 commented Oct 4, 2021 •
edited
Loading

here's a nvim plugin based on tree-sitter

https://github.com/p00f/nvim-ts-rainbow

maybe the queries can be re-used

@kirawi kirawi added the E-easy Call for participation: Experience needed to fix: Easy / not much label Oct 4, 2021
@kirawi
Copy link
Member Author

kirawi commented Oct 4, 2021

Looks pretty easy to implement.

@Th3Whit3Wolf
Copy link

The plug in has issues with performance. I'm not sure if this is an implementation issue or not though.

@kirawi kirawi self-assigned this Nov 7, 2021
@kirawi kirawi removed the E-easy Call for participation: Experience needed to fix: Easy / not much label Nov 7, 2021
@kirawi kirawi removed their assignment Nov 13, 2021
@kirawi kirawi added the E-good-first-issue Call for participation: Issues suitable for new contributors label Nov 13, 2021
@SoraTenshi
Copy link
Contributor

SoraTenshi commented Jun 16, 2022 •
edited
Loading

i might want to have a look at that.
I can not promise that i will be successful though.
Seems to be too difficult for me as of right now.
As this task requires a bit more understanding of the editor + tree-sitter

@the-mikedavis the-mikedavis removed the E-good-first-issue Call for participation: Issues suitable for new contributors label Jun 21, 2022
@the-mikedavis
Copy link
Member

I think I have a clever idea of how to do this efficiently. I'll make a PR

@the-mikedavis the-mikedavis self-assigned this Jun 21, 2022
@the-mikedavis the-mikedavis linked a pull request Jul 2, 2022 that will close this issue
Rainbow tree-sitter matches 🌈 #2857
Draft
omentic added a commit to omentic/helix-ext that referenced this issue Nov 1, 2023
@omentic @the-mikedavis
Add rainbow tree-sitter highlights
eaf8d6d 
ref: helix-editor/helix#695
ref: helix-editor/helix#2857

Co-authored-by: Michael Davis <[email protected]>
@kirawi kirawi mentioned this issue Jan 18, 2024
Closed
omentic pushed a commit to omentic/helix-ext that referenced this issue May 1, 2024
@the-mikedavis @omentic
Add rainbow tree-sitter highlights
666e6ea 
ref: helix-editor/helix#695
ref: helix-editor/helix#2857
omentic pushed a commit to omentic/helix-ext that referenced this issue May 1, 2024
@the-mikedavis @omentic
Add rainbow tree-sitter highlights
6ea9963 
ref: helix-editor/helix#695
ref: helix-editor/helix#2857
omentic pushed a commit to omentic/helix-ext that referenced this issue May 1, 2024
@the-mikedavis @omentic
Add rainbow tree-sitter highlights
ee36090 
ref: helix-editor/helix#695
ref: helix-editor/helix#2857
omentic pushed a commit to omentic/helix-ext that referenced this issue May 1, 2024
@the-mikedavis @omentic
Add rainbow tree-sitter highlights
5e83738 
ref: helix-editor/helix#695
ref: helix-editor/helix#2857
omentic pushed a commit to omentic/helix-ext that referenced this issue May 1, 2024
@the-mikedavis @omentic
Add rainbow tree-sitter highlights
9a3f23b 
ref: helix-editor/helix#695
ref: helix-editor/helix#2857
@HealsCodes
Copy link

HealsCodes commented May 27, 2024 •
edited
Loading

good to see this pseudo-PR pick back up, the feature would be very nice to have.

Is there any rough idea if / when it might actually become a real PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@the-mikedavis the-mikedavis

Labels
A-helix-term Area: Helix term improvements A-theme Area: Theme and appearence related C-enhancement Category: Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rainbow tree-sitter matches 🌈 the-mikedavis/helix
7 participants
@HealsCodes @archseer @SoraTenshi @the-mikedavis @ttys3 @Th3Whit3Wolf @kirawi