-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Permalink
Loading
Choose a base ref
{{ refName }}
default
Loading
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: helix-editor/helix
base: 3feb2a28029d778ddeaa01b8defbc77ca8c322a5
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: helix-editor/helix
compare: f19fb10054b9dc2b30c12a0ff31c85f17c268e55
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 20 commits
- 41 files changed
- 9 contributors
Commits on Mar 10, 2023
-
allow LSP insert text to replace non-matching prefixes (#5469)
Most LSPs will complete case-insensitive matches, particularly from lowercase to uppercase. In some cases, notably Pyright, this is given as a simple insert text instead of TextEdit. When this happens, the prefix text was left unedited.
Configuration menu - View commit details
-
Copy full SHA for 9b4326b - Browse repository at this point
Copy the full SHA 9b4326bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e91289f - Browse repository at this point
Copy the full SHA e91289fView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdec933 - Browse repository at this point
Copy the full SHA cdec933View commit details -
Add API to create a Transaction from potentially overlapping changes
This commit adds new functions to `Transaction` that allow creating edits that might potentially overlap. Any change that overlaps previous changes is ignored. Furthermore, a utility method is added that also drops selections associated with dropped changes (for transactions that are created from a selection). This is needed to avoid crashes when applying multicursor autocompletions, as the edit from a previous cursor may overlap with the next cursor/edit.
Configuration menu - View commit details
-
Copy full SHA for 2b64a64 - Browse repository at this point
Copy the full SHA 2b64a64View commit details -
fix snippet bugs and multicursor completion edgecases
Multicursor completions may overlap and therefore overlapping completions must be dropped to avoid crashes. Furthermore, multicursor edits might simply be out of range if the word before/after the cursor is shorter. This currently leads to crashes, instead these selections are now also removed for completions. This commit also significantly refactors snippet transaction generation so that tabstops behave correctly with the above rules. Furthermore, snippet tabstops need to be carefully mapped to ensure their position is correct and consistent with our selection semantics. Finally, we now keep a partially updated Rope while creating snippet transactions so that we can fill information into snippets that depends on the position in the document.
Configuration menu - View commit details
-
Copy full SHA for b1f7528 - Browse repository at this point
Copy the full SHA b1f7528View commit details -
Configuration menu - View commit details
-
Copy full SHA for d63e570 - Browse repository at this point
Copy the full SHA d63e570View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98415f2 - Browse repository at this point
Copy the full SHA 98415f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1661e4b - Browse repository at this point
Copy the full SHA 1661e4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3907358 - Browse repository at this point
Copy the full SHA 3907358View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d230e7 - Browse repository at this point
Copy the full SHA 3d230e7View commit details
Commits on Mar 11, 2023
-
* misc: missing inline, outdated link * doc: Add new theme keys and config option to book * fix: don't panic in Tree::try_get(view_id) Necessary for later, where we could be receiving an LSP response for a closed window, in which case we don't want to crash while checking for its existence * fix: reset idle timer on all mouse events * refacto: Introduce Overlay::new and InlineAnnotation::new * refacto: extract make_job_callback from Context::callback * feat: add LSP display_inlay_hint option to config * feat: communicate inlay hints support capabilities of helix to LSP server * feat: Add function to request range of inlay hint from LSP * feat: Save inlay hints in document, per view * feat: Update inlay hints on document changes * feat: Compute inlay hints on idle timeout * nit: Add todo's about inlay hints for later * fix: compute text annotations for current view in view.rs, not document.rs * doc: Improve Document::text_annotations() description * nit: getters don't use 'get_' in front * fix: Drop inlay hints annotations on config refresh if necessary * fix: padding theming for LSP inlay hints * fix: tracking of outdated inlay hints should not be dependant on document revision (because of undos and such) * fix: follow LSP spec and don't highlight padding as virtual text * config: add some LSP inlay hint configs
Configuration menu - View commit details
-
Copy full SHA for bdcd4d9 - Browse repository at this point
Copy the full SHA bdcd4d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 171d28d - Browse repository at this point
Copy the full SHA 171d28dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 81601b1 - Browse repository at this point
Copy the full SHA 81601b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7479261 - Browse repository at this point
Copy the full SHA 7479261View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72e3174 - Browse repository at this point
Copy the full SHA 72e3174View commit details -
Configuration menu - View commit details
-
Copy full SHA for aaf6708 - Browse repository at this point
Copy the full SHA aaf6708View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8614b91 - Browse repository at this point
Copy the full SHA 8614b91View commit details -
Allow explicit newlines in test DSL
The current test DSL currently has no way to express being at the end of a line, save for putting an explicit LF or CRLF inside the `#[|]#`. The problem with this approach is that it can add unintended extra new lines if used in conjunction with raw strings, which insert newlines for you. This is a simple attempt to mitigate this problem. If there is an explicit newline character at the end of the selection, and then it is immediately followed by the same newline character at the right end of the selection, this following newline is removed. This way, one can express a cursor at the end of a line explicitly.
Configuration menu - View commit details
-
Copy full SHA for 0f98482 - Browse repository at this point
Copy the full SHA 0f98482View commit details -
test::plain uses char indices when it should use byte indices
Configuration menu - View commit details
-
Copy full SHA for d4eef5c - Browse repository at this point
Copy the full SHA d4eef5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f19fb10 - Browse repository at this point
Copy the full SHA f19fb10View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 3feb2a28029d778ddeaa01b8defbc77ca8c322a5...f19fb10054b9dc2b30c12a0ff31c85f17c268e55