Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heimdal-7.7.1 and heimdal-7.8.0 are missing CVE-2022-42898 fix #1161

Open
riastradh opened this issue Jun 19, 2023 · 2 comments
Open

heimdal-7.7.1 and heimdal-7.8.0 are missing CVE-2022-42898 fix #1161

riastradh opened this issue Jun 19, 2023 · 2 comments

Comments

@riastradh
Copy link

riastradh commented Jun 19, 2023

Describe the bug
The Heimdal 7.7.1 release notes say:

This release fixes the following Security Vulnerabilities:

Likewise the Heimdal 7.8.0 release notes:

This release includes both the Heimdal 7.7.1 Security Vulnerability fixes and non-Security bug fixes/improvements.

Security Vulnerabilities:

However, the fix does not appear to have been applied in the heimdal-7.7.1 tag (https://github.com/heimdal/heimdal/blob/heimdal-7.7.1/lib/krb5/store-int.c#L52):

unsigned long v = 0;

Nor does it appear to have been applied in the heimdal-7.8.0 tag (https://github.com/heimdal/heimdal/blob/heimdal-7.8.0/lib/krb5/store-int.c#L52):

unsigned long v = 0;

Compare master as of today:

uint64_t v = 0;

To Reproduce
code inspection

Expected behavior
fix exists on 7.7.1 and 7.8.0 (well, a bit late for that now, but maybe 7.7.2 and 7.8.1, along with the CVE-2022-45142 fix?)

@riastradh
Copy link
Author

Ping? I know the dominant platforms these days are LP64 and thus unaffected by this, but it is a security issue for anyone on LP32 like i386 and armv7 and the release notes appear to be misleading users into thinking it's fixed.

@nicowilliams
Copy link
Contributor

Thanks for this report. I don't know how that happened, but we'll prep new releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants