Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix README #8

Open
altsheets opened this issue Feb 2, 2017 · 4 comments
Open

fix README #8

altsheets opened this issue Feb 2, 2017 · 4 comments

Comments

@altsheets
Copy link

altsheets commented Feb 2, 2017

Your https://github.com/Heat-Ledger-Ltd/heat-ui/blob/master/README.md is incomplete:

additionally needed on Debian:

sudo apt-get install nodejs-legacy

And: After

npm init 

don't you have to do

npm install

?

And: Could you not simply put tsd into the package.json? If not, then this is needed:

sudo npm install tsd -g

And: gulp play reports an error:

tools/typings/angularjs/angular-animate.d.ts(134,47): error TS2304: Cannot find name 'IAnimateCallbackObject'.

but ... the webclient at https://localhost:9001/dist/#/ does work. Very good.


[HEAT] 15806825503205248904

@altsheets
Copy link
Author

to make starting the server easier:

echo "gulp play" > gulp-play.sh
chmod +x gulp-play.sh

then that file can be double clicked.

@redcub
Copy link

redcub commented Mar 17, 2017

To fix the cant find IAnimateCallbackObject
interface IAnimateCallbackObject { eventFn(element: Node, doneFn: () => void): Function; }
insert this in line 144 in heat-ui/tools/typings/angularjs/angular-animate.d.ts
so basically right after interface IAnimateProvider

@dmdeklerk
Copy link
Member

@redcub TSD has been deprecated in favor of https://github.com/typings/typings we should eventually move there.

@altsheets same goes about tsd being deprecated. npm install is needed indeed. the README is pretty old since then lots of packages have been updated and we've migrated from nwjs to electron i dont think node-legacy would work anymore. pushing some delayed changes in a few minutes guess it will determine that

@altsheets
Copy link
Author

Thanks!

To fix the cant find IAnimateCallbackObject ...

No. Please when you have fixed your code, put a msg here, so that I notice.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants