Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Locale files are not uploading to Shopify #90

Open
jzelaya-manduka opened this issue Apr 30, 2021 · 2 comments
Open

[BUG] Locale files are not uploading to Shopify #90

jzelaya-manduka opened this issue Apr 30, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@jzelaya-manduka
Copy link

Describe the bug
When using either packer start or packer watch, modifying existing locale files locally does not upload changes to the Shopify theme. New files added to the locales folder do not upload either.

To Reproduce
Steps to reproduce the behavior:

  1. packer start
  2. make changes in en.default.json and save
  3. refresh the browser

Expected behavior
"Uploading to Shopify..." should appear in the console and changes should be seen in the browser.

System (please complete the following information):

  • OS: Mac OSX 11.3
  • Node Version v12.22.1
  • NPM Version 6.14.12
  • Browser chrome 90.0.4430.93

Packer (please complete the following information):

  • Version v2.1.5

Theme (please complete the following information):

@jzelaya-manduka jzelaya-manduka added the bug Something isn't working label Apr 30, 2021
@ghost
Copy link

ghost commented May 12, 2021

I have the same issue. Is there any update on this?

@thebiggianthead
Copy link

Looks like this is also true of settings_schema.json – looks like the command only looks for Liquid files being updated. Would likely be worth observing JSON files too, as these are changed frequently during theme development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants