-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WorkspaceDidChangeConfiguration
does not work if static?
#547
Comments
We certainly do handle those requests automatically, and also support them being set as static handlers. However, there is no server capability for these, so AFAICT whether or not to send them is entirely up to the client. But perhaps if you dynamically register then that tells the client you want them? I suspect what is happening is that this is actually VS Code dropping support for the old push-based configuration model. See the text here: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspace_configuration That seems to confirm my suspicion. This is a problem for the So I think what this means is that |
I opened microsoft/language-server-protocol#1888 on the spec, but for now we need to deal with the current reality. |
Using an older |
@michaelpj it appears to work, thanks! |
Great, I'll try and get the lsp-test stuff done and get this merged and released. |
Released a version with the fix. |
I just spent quite a bit of time trying to get VS Code to send me notifications when the configuration for my language server changes. I managed to get it to work by manually calling
registerCability
on the titular method in theSMethod_Initialized
, bur for some reason it would not work ifWorkspaceDidChangeConfiguration
was listed in the static handlers. This seems confusing.Given that the library already does quite a lot of custom handling of configuration processing, it would be a lot less confusing if the static version just worked. In fact, wouldn't it make sense to always enable this, given that the options contain an
onConfigChange
function?The text was updated successfully, but these errors were encountered: