-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
systemd notify capabilities are not enabled by default #14371
Labels
Comments
Seems reasonable, feel free to work up a PR. |
This was referenced Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In #11517, the ability to notify systemd with the status of the vault server was added but the default Vault systemd unit file provided in the official packages does not set
Type=notify
so this feature doesn't ever get used when installing through package managers.I only happened to realize this was even a feature due to having debug logs enabled on a dev environment where I saw the log message saying
would have sent systemd notification (systemd not present)
and got a bit worried since this machine definitely is a systemd box. Took a bit of digging to find the commit adding this and the comment about the systemd service having to have theType=notify
in it.I don't see any reason that the unit file for Vault shouldn't be updated with
Type=notify
set and am happy to open a PR if there aren't any objections to it.To Reproduce
Steps to reproduce the behavior:
would have sent systemd notification (systemd not present)
shortly after starting up.systemctl edit vault
and paste the code below in the editor and save.systemctl daemon-reload && systemctl restart vault
and you will now see the messagesent systemd notification: notification=READY=1
Expected behavior
Vault's systemd unit file should properly configure it's type as
notify
when installed from a package.Environment:
Vault server configuration file(s):
The text was updated successfully, but these errors were encountered: