Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Fix import of RouteTable with destination prefixes #9686

Merged
merged 2 commits into from
Oct 28, 2016

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Oct 28, 2016

Route Tables can get routes that do not have a DestinationCidrBlock by way of aws_vpc_endpoint. These Routes are ignored in reading aws_route_table and so we should ignore them here as well.

Fixes #8225 , adds test

@stack72
Copy link
Contributor

stack72 commented Oct 28, 2016

LGTM!

@stack72 stack72 merged commit 01e8bd1 into master Oct 28, 2016
@stack72 stack72 deleted the b-aws-route-table-import branch October 28, 2016 23:01
mathieuherbert pushed a commit to mathieuherbert/terraform that referenced this pull request Oct 30, 2016
…hicorp#9686)

* add test failure

* provider/aws: Skip import of routes that contain destination prefix ids
gusmat pushed a commit to gusmat/terraform that referenced this pull request Dec 6, 2016
…hicorp#9686)

* add test failure

* provider/aws: Skip import of routes that contain destination prefix ids
@ghost
Copy link

ghost commented Apr 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crash when importing aws_route_table
2 participants