fix: handle nil expressions in earlydecoder when parsing outputs with incomplete provider defined functions #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
commented
Feb 23, 2024
11 tasks
dbanck
requested changes
Feb 28, 2024
There was a problem hiding this comment.
There are about 15 other calls to attr.Expr in the earlydecoder that we need to handle more gracefully. Even though most of the attributes only allow literal types and function calls are not allowed, we still shouldn't crash when a user types a function call.
… incomplete provider defined functions
… defined function expressions
2a240b7
to
e096c50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.