r/virtual_machine: Split disk Diff #481
Conversation
Split virtual disk diff function into validation and normalization. Some normalization tasks should not be performed on new or unmatched virtual disks, but validation should be performed on all.
|
Hey @bill-rich, the problems that we talked about with the diff validation on new disks is happening because the entire diff validation is happening during the stage where we are comparing resources in state with the current state of configuration, remember. I noticed that Also, I was thinking that We should also throw in some Thanks! |
Move some tasks from general disk diff function to existing disk function as they are only necessary when dealing with disks already in state.
| }, | ||
| { | ||
| Config: testAccResourceVSphereVirtualMachineConfigMultiHighBusInsufficientBus(), | ||
| ExpectError: regexp.MustCompile("unit_number on disk \"disk1\" too high \\(15\\) - maximum value is 14 with 1 SCSI controller\\(s\\)"), |
There was a problem hiding this comment.
Can this be in the first step or is there a reason why the VM needs to be created first?
There was a problem hiding this comment.
That one is included to make sure the diff validation is working on updates and when there is already a disk present (disk0). This same case is tested at VM creation at: https://github.com/terraform-providers/terraform-provider-vsphere/blob/8027f5e805e92851893755bffa34be1efb9cb2c0/vsphere/resource_vsphere_virtual_machine_test.go#L362
The two tests added in this commit may be a bit overkill as there isn't a specific past bug that I'm trying to check for, but trying to cover other cases where the behavior is slightly different.
There was a problem hiding this comment.
I dropped the two update tests, so its just the original TestAccResourceVSphereVirtualMachine_highDiskUnitInsufficientBus again.
ghost
locked and limited conversation to collaborators
Split virtual disk diff function into validation and normalization. Some
normalization tasks should not be performed on new or unmatched virtual
disks, but validation should be performed on all.