Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_codebuild_project is missing a valid enivornment type (WINDOWS_SERVER_2019_CONTAINER) #14335

Closed
CianGrimnir opened this issue Jul 24, 2020 · 3 comments · Fixed by #14532
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/codebuild Issues and PRs that pertain to the codebuild service.
Milestone

Comments

@CianGrimnir
Copy link
Contributor

CianGrimnir commented Jul 24, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The aws_codebuild_project resource environment type currently only supports a value of WINDOWS_CONTAINER for the Windows ecosystem. but WINDOWS_SERVER_2019_CONTAINER should also be an option available to select the property (it is supported by aws-sdk-go).

The code in v2.70.0 that this applies to is:

155                         "type": {
156                             Type:     schema.TypeString,
157                             Required: true,
158                             ValidateFunc: validation.StringInSlice([]string{
159                                 codebuild.EnvironmentTypeLinuxContainer,
				       codebuild.EnvironmentTypeLinuxGpuContainer,
				       codebuild.EnvironmentTypeWindowsContainer,
				       codebuild.EnvironmentTypeArmContainer,
160                             }, false),
161                         },

New or Affected Resource(s)

  • aws_codebuild_project

Potential Terraform Configuration

resource "aws_codebuild_project" "testing" {
  name          = var.build_project_name
  description   = "testing codebuild project"
  build_timeout = "5"
  service_role  = aws_iam_role.codebuild.arn

  artifacts {
    type                = "CODEPIPELINE"
  }

  environment {
    compute_type    = var.codebuild_compute_type
    image           = var.codebuild_build_image
    type            = "WINDOWS_SERVER_2019_CONTAINER"
    privileged_mode = "false"
  }

  source {
    type            = "CODEPIPELINE"
  }
}

References

Requires AWS SDK v1.33.8:

@CianGrimnir CianGrimnir added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 24, 2020
@ghost ghost added the service/codebuild Issues and PRs that pertain to the codebuild service. label Jul 24, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 24, 2020
@bflad bflad added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 24, 2020
@bflad bflad added this to the v3.2.0 milestone Aug 13, 2020
@bflad
Copy link
Contributor

bflad commented Aug 13, 2020

Support for this has been merged and will release with version 3.2.0 of the Terraform AWS Provider, later today. Thanks to @RakeshCodeBase for the implementation. 👍

@ghost
Copy link

ghost commented Aug 14, 2020

This has been released in version 3.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/codebuild Issues and PRs that pertain to the codebuild service.
Projects
None yet
2 participants