Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it worth detecting common error of unescaped ${aws:...}? #460

Closed
radeksimko opened this issue Apr 13, 2021 · 3 comments
Closed

Is it worth detecting common error of unescaped ${aws:...}? #460

radeksimko opened this issue Apr 13, 2021 · 3 comments

Comments

@radeksimko
Copy link
Member

It seems that users keep running into this problem despite our best efforts in documenting it:

hashicorp/terraform-ls#455

Is it worth adding some context to that error message in cases where we scan : after aws?

@bgray-onica
Copy link

Imo yes, as I was even questioning if I was doing something wrong but had no idea what to search for. And as such, failed when I did search.

@radeksimko
Copy link
Member Author

#462 improved the diagnostic message and hashicorp/terraform-ls#463 will bring that change into the language server / VS Code.

With that in mind I'm closing this issue.

@bgray-onica
Copy link

Awesome thank you @radeksimko and @apparentlymart! Greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants