ResponseLogHook is not called if error is nil

[tarasmatsyk]

From what I understood you are calling log hook only if response is present, which makes sense. However hooks in my perspective is something called regardless of whether response is successful or not. For sure I can use checkRetry feature to get notified when response is returned, but maybe it would be possible to add something like OnErrorLogHook to ensure http.Do is fully wrapped?

here is a piece of code I am referring to:
https://github.com/hashicorp/go-retryablehttp/blob/master/client.go#L523

Let me know if this makes sense, I can add go with a PR

[jefferai]

ResponseLogHook is actually called below that line and is called so long as err is not nil, not if response is not nil.

[tarasmatsyk]

Nice catch! That's what I was trying to say, However hooks in my perspective is something called regardless of whether response is successful or not.

Do you think it makes sense to let users catch errors if any? I mean, it really could be helpful to know that response is finished even with error as checkRetry seems to be a wrong place for this kind of functionality.