Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client.Kill() should close connections in Test mode #215

Open
RealFatCat opened this issue Oct 10, 2022 · 0 comments
Open

client.Kill() should close connections in Test mode #215

RealFatCat opened this issue Oct 10, 2022 · 0 comments

Comments

@RealFatCat
Copy link

RealFatCat commented Oct 10, 2022 •
edited
Loading

Hi,
For now, if plugin runs in test mode, client will not close its connections, because of this check, that process == nil runs early:
https://github.com/hashicorp/go-plugin/blob/master/client.go#L414

This can cause memory leaks in plugin.

Original issue in terraform-provider-aws:
hashicorp/terraform-provider-aws#26130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RealFatCat