Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin process exited error="signal: terminated" #203

Open
hiyosi opened this issue Jun 24, 2022 · 0 comments
Open

plugin process exited error="signal: terminated" #203

hiyosi opened this issue Jun 24, 2022 · 0 comments

Comments

@hiyosi
Copy link

hiyosi commented Jun 24, 2022

If the parent process is managed by the systemd and the default KillSignal=SIGTERM and KillMode=control-group are set, the signal SIGTERM is also sent to the child process.

And, I found the server code does not handle SIGTERM, so it shutdown abnormally.
https://github.com/hashicorp/go-plugin/blob/v1.4.4/server.go#L432

Should it handle not only Interrupt but other signals(e.g.SIGTERM)?
Or It can not shut down the plugin properly in case of above? It must be kill with KillMode=process ?

Regarding the log level.
Prior to v1.4.3, the message logged as debug level.
In v1.4.4, log level has been changed to error.
https://github.com/hashicorp/go-plugin/blob/v1.4.4/client.go#L638-L640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant