Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create do_invite functions in fruniques pallet #414

Open
tlacloc opened this issue Apr 19, 2023 · 1 comment
Open

Create do_invite functions in fruniques pallet #414

tlacloc opened this issue Apr 19, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@tlacloc
Copy link
Contributor

tlacloc commented Apr 19, 2023

Description

Currently, the invite extrinsic is not encapsulated in a helper function, meaning that only users with admin permissions can invite other users to the system. We want to create a helper function called do_invite that encapsulates the invite extrinsic and can be used by any user, regardless of their permissions.

Why

By encapsulating the invite extrinsic in a helper function, we will make it easier for users to invite others to the system, which can improve user adoption and engagement. Additionally, this will make the codebase more modular and easier to maintain in the long term.

Changes

  • Create a new helper function called do_invited that encapsulates the invite extrinsic
  • Update the codebase to use do_invited instead of calling the invite extrinsic directly
  • Call that function in Afloat when a user signs in

Impact

Users without admin permissions will be able to invite others to the system
The codebase will be more modular and easier to maintain in the long term
There may be minor performance implications due to the added layer of abstraction, but this is not expected to be significant
Additional Notes
It is important to ensure that the new do_invited function follows best practices for security and data privacy to prevent unauthorized access to the system.
This change may require updating documentation or user-facing materials to reflect the new process for inviting others to the system.

@Dreyhh
Copy link
Contributor

Dreyhh commented Apr 21, 2023

done 47161ab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants