From 2ecd1e26a2b2c5e251e4be11f4542c300aa53f36 Mon Sep 17 00:00:00 2001 From: Enver Bisevac Date: Fri, 1 Dec 2023 15:18:35 +0100 Subject: [PATCH 1/2] Update ci-lint.yml --- .github/workflows/ci-lint.yml | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci-lint.yml b/.github/workflows/ci-lint.yml index 36e2e319f3..84f4acf021 100644 --- a/.github/workflows/ci-lint.yml +++ b/.github/workflows/ci-lint.yml @@ -12,13 +12,10 @@ permissions: # Optional: allow read access to pull request. Use with `only-new-issues` option. # pull-requests: read jobs: - golangci: - name: lint + web: + name: CI linter for js/ts runs-on: ubuntu-latest steps: - - uses: actions/setup-go@v3 - with: - go-version: 1.19 - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: @@ -31,11 +28,23 @@ jobs: yarn install yarn check:all yarn build + gitness: + name: CI linter for go + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - uses: actions/setup-go@v4 + with: + go-version: '1.20' + - name: get dependencies + run: | + mkdir -p ./web/dist + touch ./web/dist/empty.txt - name: golangci-lint uses: golangci/golangci-lint-action@v3 with: # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version - version: v1.49 + version: v1.54 # Optional: working directory, useful for monorepos # working-directory: somedir From 66f74a23c74457ec20eea662e73b5c77f359f79e Mon Sep 17 00:00:00 2001 From: Enver Bisevac Date: Fri, 1 Dec 2023 19:20:49 +0000 Subject: [PATCH 2/2] upgrade golang to 1.20 --- Dockerfile | 2 +- README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Dockerfile b/Dockerfile index 1a4f43fc26..05650e2f14 100644 --- a/Dockerfile +++ b/Dockerfile @@ -18,7 +18,7 @@ RUN yarn && yarn build && yarn cache clean # ---------------------------------------------------------# # Build gitness image # # ---------------------------------------------------------# -FROM --platform=$BUILDPLATFORM golang:1.19-alpine as builder +FROM --platform=$BUILDPLATFORM golang:1.20-alpine as builder RUN apk update \ && apk add --no-cache protoc build-base git diff --git a/README.md b/README.md index ca91034257..1719f7220a 100644 --- a/README.md +++ b/README.md @@ -39,7 +39,7 @@ For more information on Drone, please visit [drone.io](https://www.drone.io/). ## Gitness Development ### Pre-Requisites -Install the latest stable version of Node and Go version 1.19 or higher, and then install the below Go programs. Ensure the GOPATH [bin directory](https://go.dev/doc/gopath_code#GOPATH) is added to your PATH. +Install the latest stable version of Node and Go version 1.20 or higher, and then install the below Go programs. Ensure the GOPATH [bin directory](https://go.dev/doc/gopath_code#GOPATH) is added to your PATH. Install protobuf - Check if you've already installed protobuf ```protoc --version```