Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add login redirect for 404s #1266

Closed
donny-dont opened this issue Oct 27, 2015 · 7 comments
Closed

Add login redirect for 404s #1266

donny-dont opened this issue Oct 27, 2015 · 7 comments

Comments

@donny-dont
Copy link

If a user isn't logged in and follows a Drone link it will 404 ala GitHub. This can cause some confusion for users as they don't see anything and don't know they aren't logged in. It would be great to have a login prompt if they're not logged in to avert any questions about access.

@bradrydzewski bradrydzewski added this to the Unplanned milestone Oct 28, 2015
@macb
Copy link

macb commented Nov 19, 2015

I want to add some support for this. My org generally discovers what drone is via a PR hook, so they click and get a 404 and are confused. :)

@adamstep
Copy link

This is also an issue in our organization. @bradrydzewski would you be opposed having this as a configurable option (through an environment variable)?

@bradrydzewski
Copy link

@adamstep I think replacing the ambiguous 404 message with a prompt to login will probably solve the issue, as long as the login can re-direct back to that page. If you login and that repository doesn't exists or you don't have access, you'll get a 404 (hopefully with a more intuitive message)

@adamstep
Copy link

Sounds good, I will look into this.

@gdubicki
Copy link

gdubicki commented Jun 7, 2016

+1

@gtaylor
Copy link

gtaylor commented Jun 7, 2016

@gdubicki Please don't add +1 comments to issues, as it notifies all subscribers. Use the reaction button on the issue.

@bradrydzewski
Copy link

Closing now that we have the upcoming 0.5 UI merged which makes it much more clean when you need to authenticate.

I also have a separate issue for improving the error messaging in the main content pane. I'll be tracking this at https://github.com/drone/drone-ui/issues/20

screen shot 2016-07-11 at 4 04 38 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants